sander
/
MuDBase
1
0
Fork 0
Code Issues 17 Pull Requests Projects 6 Releases Wiki Activity
Labels Milestones
New Issue

Nested combinatorial logic not working (Knex.js query building) #17

Open
opened 5 years ago by sander · 0 comments
sander commented 5 years ago
Owner

Version: fb4439dec9

Try:

  • making an "And" block in the front-end with two things which will yield no result together (e.g. artist X AND song Y which is not by that artist).
  • OR that block with something else.
  • Suddenly, all results appear as if all the individual elements were ORed.

Likely there is something wrong with how we build the Knex query.

Also, there should be better tests to prevent regressions on this kind of stuff.

Version: fb4439dec93e043f65ff75626edb236322b3a845 Try: - making an "And" block in the front-end with two things which will yield no result together (e.g. artist X AND song Y which is not by that artist). - OR that block with something else. - Suddenly, all results appear as if all the individual elements were ORed. Likely there is something wrong with how we build the Knex query. Also, there should be better tests to prevent regressions on this kind of stuff.
sander added the
backend
bug
 labels 5 years ago
sander added this to the Core project 5 years ago
sander modified the project from Core to Bugs 5 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
cypress
editsong
expand_detailspages
manage_cleardb
master
statistics_page
ytm_integration
Labels
Apply labels
Clear labels
backend
Work on the back-end. bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature frontend
Work on the front-end. invalid
Something is wrong postgres question
More information is needed sqlite3 wontfix
This won't be fixed
No Label backend bug duplicate enhancement frontend invalid postgres question sqlite3 wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Bugs
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sander/MuDBase#17
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes